Document that v:resource.record is not to be used as generic record l…

[cweiske]

…oader

Related: #960

It bit me today when using it in the backend preview with a disabled/hidden record :(

[NamelessCoder]

Files in Documentation/ViewHelpers are auto-generated whenever a ViewHelper class file changes - these changes would be overwritten by that automation. The other change is fine (except the .rst file doesn't need to be changed, that's automated), but this one for v:resource.record needs to be added in the RecordViewHelper directly.

[cweiske]

Fixed.

[NamelessCoder]

Thanks! Reported problems with code style are totally unrelated, caused by yet another phpstan update upstream which again changed which issues are reported - this happens so damn frequently, I should probably nail the phpstan dependency to a specific version...

[cweiske]

I once ranted on the pear-dev mailing list about each php_codesniffer update adding new rules that my code did not follow. It turned out I was using phpcs wrong and ran it without a coding style and all new rules were used. The correct way was to choose a coding style with a hard list of rules, and stick to it.
Maybe phpstan has something similar.

[NamelessCoder]

Could be. Right now I'm using phpstan with just a level, which definitely changes the detection rules very frequently - PHPCS is being used with a standard, PSR2, which hasn't changed.

[NamelessCoder]

If you pull dev-development and rebase this branch the checks should now pass. Or you can enable the "edits from maintainers" option and I'll take care of it for you ;)

[cweiske]

I don't see the "edits from maintainers" option anywhere here :(
Probably because:

On user-owned forks, if you want to allow anyone with push access to the upstream repository to make changes to your pull request, select Allow edits from maintainers.

and I am hosting the vhs fork at my company's org account, not my personal one.

[NamelessCoder]

and I am hosting the vhs fork at my company's org account, not my personal one.

That makes sense. No worries, we can work with this as long as you're OK with me asking you to rebase or make minor changes yourself every now and then!