Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add option to disable translation fallback in menus #1499

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

mbrodala
Copy link
Contributor

Fixes #1498

@mbrodala
Copy link
Contributor Author

(Build failure is unrelated.)

@neufeind
Copy link
Contributor

@mbrodala Can you do a rebase of this?

@mbrodala mbrodala force-pushed the menu-normal-when-no-language branch 2 times, most recently from c1cf041 to 555e329 Compare October 31, 2018 07:48
@mbrodala
Copy link
Contributor Author

Done.

Copy link
Member

@NamelessCoder NamelessCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a strategy that moves us around the issue of signature changes for menu-related methods...

@@ -60,7 +61,8 @@ public function getMenu(
array $excludePages = [],
$includeNotInMenu = false,
$includeMenuSeparator = false,
$disableGroupAccessCheck = false
$disableGroupAccessCheck = false,
$normalWhenNoLanguage = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a couple of other patches which all try to change the method signature for getMenu which in turn affects any ViewHelper using menu functions. I'm extremely hesitant to change this bit unless it gets changed to a way that will prevent future signature changes, which means either:

  • Implementing a DTO that contains menu configuration instructions.
  • Or replacing this with whichever core method allows us to read a menu without rendering it as HTML.

But I don't think we should open the flood gates for this signature change because it's going to happen again and again, and the signature will become bloated. It's already pretty bad...

@NamelessCoder NamelessCoder force-pushed the development branch 3 times, most recently from 7b35850 to 50d769b Compare June 2, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants