Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seat Button #1431

Open
wants to merge 3 commits into
base: 1.12.2
Choose a base branch
from
Open

Seat Button #1431

wants to merge 3 commits into from

Conversation

JT2AW15
Copy link

@JT2AW15 JT2AW15 commented Dec 18, 2021

Adds a seat button (P) to switch what seat of a vehicle you are in.
Especially useful for tanks, etc. with difficult to reach driver's seats

bind works to move from secondary seat to main seat, but not from main to secondary
removed hacky solution
Copy link
Member

@ChrisLane ChrisLane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the default en_US translation for key.seatSwitch.desc.

Also, has this been tested with more than one player in the vehicle on a server?

@Jomosoto
Copy link
Contributor

I just tested it in multiplayer: If the next seat is blocked, nothing happens when pressing the seat button.

@ChrisLane
Copy link
Member

I just tested it in multiplayer: If the next seat is blocked, nothing happens when pressing the seat button.

I think this feature should still continue to cycle through available seats rather than stopping when the next seat is occupied (assuming that's what you meant).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants