Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove mailer lite #4705

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: Remove mailer lite #4705

wants to merge 7 commits into from

Conversation

zachaysan
Copy link
Contributor

Changes

Removing mailer lite from the codebase since it has been deprecated.

How did you test this code?

Relying on existing test suite to handle failures.

@zachaysan zachaysan requested a review from a team as a code owner October 8, 2024 19:40
@zachaysan zachaysan requested review from matthewelwell and removed request for a team October 8, 2024 19:40
Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 1:53pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Oct 9, 2024 1:53pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Oct 9, 2024 1:53pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4705 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4705 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4705 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4705 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4705 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Uffizzi Ephemeral Environment deployment-57046

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4705

📄 View Application Logs etc.

What is Uffizzi? Learn more!

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (cd13caa) to head (41992f2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4705    +/-   ##
========================================
  Coverage   97.21%   97.21%            
========================================
  Files        1171     1169     -2     
  Lines       40651    40474   -177     
========================================
- Hits        39517    39345   -172     
+ Misses       1134     1129     -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think there's an environment variable that we can still remove in the production task definition here.

@zachaysan
Copy link
Contributor Author

Looks good, but I think there's an environment variable that we can still remove in the production task definition here.

Nice catch @matthewelwell I've removed the env var.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants