Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Trivy enhancements #4703

Merged
merged 7 commits into from
Oct 8, 2024
Merged

ci: Trivy enhancements #4703

merged 7 commits into from
Oct 8, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 8, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This moves Trivy database caching from the PR workflow to a new cron-based workflow, which also runs Trivy against main tags every three hours.

This fixes CI for external contributions and makes sure we have up-to-date security reports for current main.

How did you test this code?

This is a CI change.

- Don't pull Trivy databases for PR worklow
- Add Trivy scan cron workflow
Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 2:47pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 2:47pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 2:47pm

@github-actions github-actions bot added the ci-cd Build, test and deployment related label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4703 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4703 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4703 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4703 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4703 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4703 Finished ✅ Results

@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Uffizzi Preview deployment-57025 was deleted.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

MIME_TYPE: application/vnd.aquasec.trivy.db.layer.v1.tar

scan-images:
name: Pull and republish Trivy databases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name here needs updating?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Oct 8, 2024
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (8e6b241) to head (75f7529).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4703   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files        1171     1171           
  Lines       40651    40651           
=======================================
  Hits        39517    39517           
  Misses       1134     1134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Oct 8, 2024
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Oct 8, 2024
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Oct 8, 2024
@khvn26 khvn26 added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit cd13caa Oct 8, 2024
34 checks passed
@khvn26 khvn26 deleted the ci/trivy-enhancements branch October 8, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build, test and deployment related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants