Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Rate-limited Trivy database pulls #4677

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 1, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Acommodates for Trivy rate limiting problems described in aquasecurity/trivy-action#389

How did you test this code?

This is a CI change.

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 2:28pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 2:28pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 2:28pm

@github-actions github-actions bot added the fix label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4677 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4677 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4677 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4677 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4677 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4677 Finished ✅ Results

@github-actions github-actions bot added fix and removed fix labels Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Uffizzi Preview deployment-56806 was deleted.

@khvn26 khvn26 changed the title fix: Rate-limited Trivy database pulls fix(ci): Rate-limited Trivy database pulls Oct 1, 2024
@khvn26 khvn26 added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 4bca509 Oct 1, 2024
34 checks passed
@khvn26 khvn26 deleted the fix/trivy-rate-limit branch October 1, 2024 14:35
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (59aa2f7) to head (dcdd680).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4677   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files        1166     1166           
  Lines       40436    40436           
=======================================
  Hits        39301    39301           
  Misses       1135     1135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell
Copy link
Contributor

@khvn26 it looks like this doesn't work for external PRs as is evident here. Is there something that we can do about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants