fix: Handle uncaught fetch exception

Flagsmith · Oct 3, 2024 · 7b0f640 · 7b0f640
1 parent 3d0e8b8
commit 7b0f640
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/flagsmith-core.ts b/flagsmith-core.ts
@@ -479,7 +479,7 @@ const Flagsmith = class {
                                     }
                                     if (shouldFetchFlags) {
                                         // We want to resolve init since we have cached flags
-                                        this.getFlags();
+                                        await this.getFlags();
                                     }
                                 } else {
                                     if (!preventFetch) {

diff --git a/test/init.test.ts b/test/init.test.ts
@@ -149,4 +149,28 @@ describe('Flagsmith.init', () => {
               })}),
         )
     });
+    test('should not reject when the API cannot be reached but the cache is populated', async () => {
+        const { flagsmith, initConfig, AsyncStorage } = getFlagsmith({
+            cacheFlags: true,
+            fetch: async () => {
+                return Promise.resolve({ text: () => Promise.resolve('Mocked fetch error'), ok: false, status: 401 });
+            },
+        });
+        await AsyncStorage.setItem('BULLET_TRAIN_DB', JSON.stringify(defaultState));
+        await flagsmith.init(initConfig);
+
+        expect(getStateToCheck(flagsmith.getState())).toEqual(defaultState);
+    })
+    test('should not reject when the API cannot be reached but default flags are set', async () => {
+        const { flagsmith, initConfig } = getFlagsmith({
+            defaultFlags: defaultState.flags,
+            cacheFlags: true,
+            fetch: async () => {
+                return Promise.resolve({ text: () => Promise.resolve('Mocked fetch error'), ok: false, status: 401 });
+            },
+        });
+        await flagsmith.init(initConfig);
+
+        expect(getStateToCheck(flagsmith.getState())).toEqual(defaultState);
+    })
 });