chore: add linting

[dabeeeenster]

• Adds pre-commit config
• Runs pre-commit checks as a Github Action

[riceyrice]

This brings in competing prettier config between the top-level Forge CLI folder and the Jira app folder it contains. The inner folder was intended to be self-contained with the outer folder as a convenience to avoid having to install Forge CLI globally. Notably the outer and inner folder use different versions of Node.js.

[dabeeeenster]

Ah - I missed the linting in the app folder. What do you think @matthewelwell ? We're trying to standardise on pre-commit I feel?

[matthewelwell]

Can anyone dumb this down for me so I don't have to understand the structure of the project? What's the issue and what are the options? @dabeeeenster @riceyrice

[dabeeeenster]

The app is JS/TS. Should we use native JS/TS provided linters/checkers or use pre-commit which needs python to bootstrap AFAIUI

[riceyrice]

Can anyone dumb this down for me so I don't have to understand the structure of the project? What's the issue and what are the options? @dabeeeenster @riceyrice

@matthewelwell the root of the repo contains/installs a Node 20 app (the Forge CLI). The flagsmith-jira-app folder contains/builds a Node 16 app (the Jira app). Both create a node_modules directory with different dependencies.

It's OK to install linting/formatting tools in the root if you need to make this work with pre-commit - or maybe pre-commit can be made to work with the linting/formatting tools already installed in the flagsmith-jira-app folder. If you do put the tools/config in the root folder, the existing tools/config in the app folder should be removed to avoid conflicts.

[matthewelwell]

If you do put the tools/config in the root folder, the existing tools/config in the app folder should be removed to avoid conflicts.

This makes the most sense to me.

[dabeeeenster]

OK that should be in line with what we want now

[matthewelwell]

Shouldn't this have been removed as per discussion in the main PR thread?

[dabeeeenster]

Its needed in both locations for both to work AFAICT

[matthewelwell]

@dabeeeenster not sure what the status of this one is but it seems ok to me, shall we merge?