-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better NetworkObjectEditor #741
base: main
Are you sure you want to change the base?
Conversation
Looks nice. I second this :) |
This is really nice. My only concern is that I do not speak Chinese, which is obviously on me, so I cannot reliably evaluate the language. I'd recommend making the classes partial and splitting the Chinese/English methods. EG: private static void DisplayEnglishNetworkObjectDescription()
{
// Functional code here...
}
//Placeholder
private static partial void DisplayChineseNetworkObserverDescription(); //Actual file... eg:
//NetworkObserverDrawer.Chinese.cs
private static partial void DisplayChineseNetworkObserverDescription();
{
//Functional code here..
} Then where you can switch languages put a notice below the language select tabs... This change will allow your partial classes to survive updates and will let you manage them without a bunch of back and forward. |
I will continue to improve it may take some time, there are many developers in China, I have been in contact with FN and I complained that FN's documentation is too bad, this is a fact, I will finish it, I have also written some columns, such as https://www.bilibili.com/opus/959596286425694246?spm_id_from=333.999.0.0 and https://www.bilibili.com/opus/962122238281121829?spm_id_from=333.999.0.0 |
I noticed the Chinese is still embedded in the English files. The classes would need to be partial and have a separate one for Chinese. In the English version you can choose Chinese as a language which would instruct developers to grab the Chinese files from your git. You might want to remove the custom inspector for the NetworkObject fields as well. It does look great but internally the inspectors are being reworked anyway, and we would be fighting each others code. The inspector rework for things such as NetworkObject will look very similar to yours. |
If FishNet launches a better NetworkObject in the future, this can be turned off. This is just for transition. I will delete the Chinese part first. |
I'm busy with other features and haven't paid attention to this yet. I will sort out the code as soon as possible |
Once it's done you can release it in the next version |
Can easily access the information in the NetworkObject
The button on the right side of the object can jump to the documentation of NetworkObject and add tabs