-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
615 Run tests through expressions compiled by AssemblyCompiler #616
Merged
baseTwo
merged 5 commits into
develop-2.0
from
615-change-unit-tests-to-compile-and-run-via-assemblycompiler
Oct 22, 2024
Merged
615 Run tests through expressions compiled by AssemblyCompiler #616
baseTwo
merged 5 commits into
develop-2.0
from
615-change-unit-tests-to-compile-and-run-via-assemblycompiler
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) is null`, or `null is null`
baseTwo
changed the title
Run tests through expressions compiled by AssemblyCompiler
615 Run tests through expressions compiled by AssemblyCompiler
Oct 22, 2024
@ewoutkramer please check DataSourceTests.FiltersOnSpecificProp |
@baseTwo create separate issue to fix XmlTests |
baseTwo
commented
Oct 22, 2024
It's broken on develop-2.0, it breaks in my totally unrelated branch too 😨 |
ewoutkramer
approved these changes
Oct 22, 2024
baseTwo
deleted the
615-change-unit-tests-to-compile-and-run-via-assemblycompiler
branch
October 22, 2024 14:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for
In the CqlToElmTests, the
Base.Run(..)
method was changed to accept a library as well. This will be passed toExtensions.RunLambda
, which takes anAssemblyCompiler
on its first param. This new way will run tests through an AssemblyLoadContext which has all the additional fixes in the C# generation step.This change requires packaging services to be included returned from
Base.ServiceCollection(..)
Note, two unit tests failed, which will be ignored and fixed in the next PR #614 . When searching for "
[Ignore("Will be fixed in PR 614")]
" these are the two tests:DataSourceTests.FiltersOnSpecificProp
. I'm not sure why, but this test does throw an exception as asserted anymore. Instead it successfully retrieves an array of zero Patients. Is this the intended behavior?NotEqualTest.Tuple_Equal_Tuple_Null_Equals_Null
Also, a few other unit tests had to have they cql changed so that it can compile in the
AssemblyCompiler
. In the cql the Thenull
's were changed tonull as Integer
:XmlTests
through theAssemblyCompiler
, so these tests are still compiling the lambdas directly