Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check tx result on x/foundation e2e test #1237

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Feb 14, 2024

Description

The e2e test for x/foundation did not check the error code of the txs result.
Applying this patch, the test would check the tx result included in the blocks.

minor: update gogoproto package

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Feb 14, 2024
@0Tech 0Tech changed the title test: test: check tx result on x/foundation e2e test Feb 14, 2024
@0Tech 0Tech marked this pull request as ready for review February 14, 2024 09:25
@0Tech 0Tech requested a review from a team as a code owner February 14, 2024 09:25
jaeseung-bae
jaeseung-bae previously approved these changes Feb 15, 2024
@github-actions github-actions bot added the C:x/foundation x/foundation module label Feb 15, 2024
@ulbqb ulbqb self-requested a review February 15, 2024 04:40
@0Tech 0Tech merged commit 35e6c72 into Finschia:bumpup50 Feb 16, 2024
27 checks passed
@0Tech 0Tech deleted the bumpup50-foundation branch February 16, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants