fix!: remove actions functionality

When migrating next-toggler to Tool Kit, we found out that the actions functionality were causing the n-test smoke tests to fail. The `actions` functionality was not used in our basic search of FT repos here: https://github.com/search?q=org%3AFinancial-Times+actions+path%3Atest%2Fsmoke.js++NOT+is%3Aarchived&type=code
Financial-Times · Jan 23, 2024 · 523579f · 523579f
1 parent 2da4f1a
commit 523579f
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 317 deletions.
diff --git a/README.md b/README.md
@@ -164,9 +164,6 @@ These can all be set at a suite level, as well as a URL level, like so:
 }
 ...
 ```
-### Actions
-
-n-test allows some basic actions (e.g. clicking, interacting with forms). This has been ported from [pa11y](https://github.com/pa11y/pa11y) - see the [section on their README](https://github.com/pa11y/pa11y/blob/5.0.4/README.md#actions) for more.
 
 ### FT User Sessions
 

diff --git a/lib/helpers/actions.js b/lib/helpers/actions.js
diff --git a/lib/smoke/puppeteer-page.js b/lib/smoke/puppeteer-page.js
@@ -1,6 +1,5 @@
 const getUserTokens = require('./get-user-tokens');
 const setSessionCookies = require('./set-session-cookies');
-const runAction = require('../helpers/actions');
 const { URL } = require('url');
 
 const REDIRECT_CODES = [301, 302, 303, 307, 308];
@@ -27,7 +26,6 @@ class PuppeteerPage {
 		this.dimensions = DIMENSIONS[options.breakpoint] || DIMENSIONS['XL'];
 		this.user = options.user || null;
 		this.requestHeaderPaths = options.requestHeaderPaths || [];
-		this.actions = options.actions || [];
 
 		this.pageErrors = [];
 		this.consoleMessages = [];
@@ -169,13 +167,6 @@ class PuppeteerPage {
 		const gotoResponse = await this.page.goto(this.url.toString(), { waitUntil: this.waitUntil });
 		this.response = this.response || gotoResponse;
 
-		// Run actions
-		if (this.actions.length) {
-			for (const action of this.actions) {
-				await runAction(browser, this.page, action);
-			}
-		}
-
 		if(this.check.cssCoverage) {
 			this.coverageReports = await this.page.coverage.stopCSSCoverage();
 		}

diff --git a/test/fixtures/smoke-pass.js b/test/fixtures/smoke-pass.js
@@ -61,14 +61,6 @@ module.exports = [{
 					maxPixels: 0
 				}
 			}
-		},
-		'/actions': {
-			actions: [
-				'click element .my-button'
-			],
-			elements: {
-				'.content': true
-			}
 		}
 	}
 }];
diff --git a/test/server/app.js b/test/server/app.js
@@ -154,25 +154,6 @@ app.get('/no-jank', (req, res) => {
 	`);
 });
 
-app.get('/actions', (req, res) => {
-	res.send(`
-		<body>
-			<style>
-				.content {
-					display: none;
-				}
-			</style>
-			<div class="content">Content</div>
-			<button class="my-button">Show content</button>
-			<script async defer>
-				document.querySelector('.my-button').addEventListener('click', () => {
-					document.querySelector('.content').style.display = 'block';
-				});
-			</script>
-		</body>
-	`);
-});
-
 if (!module.parent) {
 	app.listen(process.env.PORT || 3004);
 } else {

diff --git a/test/tasks/smoke.test.js b/test/tasks/smoke.test.js
@@ -21,7 +21,7 @@ describe('Smoke Tests of the Smoke', () => {
 			});
 			smoke.run()
 				.then((results) => {
-					expect(results.passed.length).toEqual(12);
+					expect(results.passed.length).toEqual(11);
 					expect(results.failed.length).toEqual(0);
 					expect(results.errors.length).toEqual(0);
 					done();