Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve loadURL blank screen issue #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kapilrc
Copy link

@kapilrc kapilrc commented Oct 15, 2020

With the base code, the loadURL returned blank html screen. This changes resolves the relative path issue and loads the requested URL.

@NeoLegends
Copy link
Member

Thanks! The changes as they currently are, however, would lead to the plugin being unable to load internet urls (as in e. g. https://google.com/). In Festify, however, we need to load internet URLs, so we cannot accept this as-is.

I suggest you add a second function to the ExternalScreen class that is specialized on loading URLs relative to the app package (e. g. loadLocalUrl) that then performs the string formatting and loads the formatted URL.

@kapilk2
Copy link

kapilk2 commented Oct 15, 2020

This is a great idea for loading local and web Urls. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants