Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the binlog #8

Merged
merged 12 commits into from
Feb 14, 2024
Merged

Add the binlog #8

merged 12 commits into from
Feb 14, 2024

Conversation

Fayti1703
Copy link
Owner

@Fayti1703 Fayti1703 commented Jan 21, 2024

TODOs:

  • Declare structures
  • Add Turn Log
  • Add Action Log
  • Add Combat Log
  • Add stringifiers/renderers
    • StandardBinlogRenderer FullStringBinlogRenderer (similar to the in-game format, but fixed bugs)
      • This also renders to a string rather than a string[].
    • CompatBinlogRenderer TraditionalBinlogRenderer (precisely the in-game format)
  • Show binlog in Accessor Deferred: BinaryMatrixEngineAccessor is incomplete #2
  • Run a couple tests Deferred: There are no tests #4

Fixes #5

@Fayti1703 Fayti1703 self-assigned this Jan 21, 2024
@Fayti1703 Fayti1703 force-pushed the feature/binlog branch 2 times, most recently from e47f410 to 0c54e63 Compare January 21, 2024 22:05
@Fayti1703
Copy link
Owner Author

Generally pretty happy with the engine implementation of the binlog so far -- PlayerID handling might need some optimization (we know the player's index at the top level!) -- but other than that, this went quite smoothly.

@Fayti1703 Fayti1703 marked this pull request as ready for review February 3, 2024 14:11
@Fayti1703
Copy link
Owner Author

Fayti1703 commented Feb 3, 2024

The core Engine implementation, plus the two renderers, is done now; still missing any sort of testing on this.

@Fayti1703
Copy link
Owner Author

Fayti1703 commented Feb 14, 2024

Merging this now and deferring test running into #4, and Accessor binlog rendering into #2.

@Fayti1703 Fayti1703 merged commit d2389e7 into trunk Feb 14, 2024
@Fayti1703 Fayti1703 deleted the feature/binlog branch February 14, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binlog is not implemented
1 participant