Issue 6, MultiMap deserializer fix #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Multimap deserializer does not honor DeserializationFeature.ACCEPT_SINGLE_VALUE_AS_ARRAY
|
First of all, thank you for submitting this: sounds like a good improvement. @stevenschlansker WDYT? |
Moving the testcases to the right test class
|
Ok, I'll take this as "yeah sure", so let's do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #6 Multimap deserializer does not honor DeserializationFeature.ACCEPT_SINGLE_VALUE_AS_ARRAY.
If the option DeserializationFeature.ACCEPT_SINGLE_VALUE_AS_ARRAY is enabled, then if there is a single value, then I create a singleton list and add the value to it.
For the same option, I am allowing multiple array values also.
Let me know if this is fine.