Add JsonParser feature to ignore trailing commas (#118) #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdhess
force-pushed
the
trailing-commas
branch
from
82f8b54
to
f48b1c0
Compare
|
Thank you for the contribution! I will have to take a look here, partly since changes occur within critical-path from performance perspective. This will probably also need to go after 2.7.0, but that will give bit more time to ensure everything works properly. |
bdhess
force-pushed
the
trailing-commas
branch
from
f48b1c0
to
ec2395c
Compare
|
I did clean up the language in the Javadoc and force-pushed over it. Hope that didn't disturb you! Looking forward to following up. |
bdhess
force-pushed
the
trailing-commas
branch
from
ec2395c
to
1893cdf
Compare
|
@cowtowncoder - can I trouble you to bump this up for review? Just rebased against the latest in master. I've run the perf tests and the difference is negligible. |
|
Forgot to add a note, but I think #117 covers same issue to some degree. It will induce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.