Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions for bor release #1

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Update actions for bor release #1

merged 3 commits into from
Feb 21, 2024

Conversation

Santonclause
Copy link

Description

New release Actions update.

Actions will be triggered manually. The workflow will:

  • check if there is a new version of release in the upstream
  • if yes, fetch new tags, checkout to the new tag and apply the patch
  • build new binaries and publish in the repo
  • build new docker image for the new tag and publish into docker hub

@Santonclause
Copy link
Author

hey @jj1980a , can you please review? We can test it manually when a new release published in the upstream.

Copy link

@jj1980a jj1980a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ephess
Copy link

ephess commented Feb 20, 2024

My only concern is that by re-using the upstream .gihub files, we may end up with merge conflicts or issues when rebasing. Should we perhaps do this instead using a new file, and disable the upstream files somehow that is less likely to result in conflicts?

Low conviction feedback.

@Santonclause
Copy link
Author

My only concern is that by re-using the upstream .gihub files, we may end up with merge conflicts or issues when rebasing. Should we perhaps do this instead using a new file, and disable the upstream files somehow that is less likely to result in conflicts?

Low conviction feedback.

@ephess thank you, valid concerns. I've put the original file back and added our actions as a manual trigger.

@Santonclause Santonclause changed the title Draft: Update actions for bor release Update actions for bor release Feb 21, 2024
@Santonclause Santonclause merged commit 0a8b65f into master Feb 21, 2024
0 of 3 checks passed
Santonclause added a commit that referenced this pull request Feb 21, 2024
@Santonclause Santonclause mentioned this pull request Feb 21, 2024
Santonclause added a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants