Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring Factory back into Atlas #67

Merged
merged 16 commits into from
Dec 11, 2023
Merged

Bring Factory back into Atlas #67

merged 16 commits into from
Dec 11, 2023

Conversation

jj1980a
Copy link
Contributor

@jj1980a jj1980a commented Dec 6, 2023

No description provided.

@jj1980a
Copy link
Contributor Author

jj1980a commented Dec 7, 2023

Code coverage for Factory currently at about 85%.
The missing function is _deployExecutionEnvironmentTemplate. Although the function is called in the constructor, it doesn't seem to make it into the coverage. Calling this function after a deployment always result in revert: 0 bytes of code. @BenSparksCode any idea how we can add it to the coverage?
Screenshot 2023-12-07 at 2 46 47 PM

BenSparksCode
BenSparksCode approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@BenSparksCode BenSparksCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jj1980a jj1980a merged commit 2289d7b into main Dec 11, 2023
3 checks passed
@jj1980a jj1980a deleted the factory-into-atlas branch December 11, 2023 06:08
@jj1980a jj1980a mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenSparksCode BenSparksCode BenSparksCode approved these changes

@Code0x2 Code0x2 Awaiting requested review from Code0x2

@thogard785 thogard785 Awaiting requested review from thogard785

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jj1980a @BenSparksCode @thogard785