Fix CI/CD #47
Merged
Fix CI/CD #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the CI/CD was always failing so we turned it off. This should fix it and allow us to turn it back on for better quality control. Summary:
lintcheck will fail if the code has not been formatted withforge fmt. The linting rules forforge fmtare still to be decided amongst the team.buildcheck will fail if the contracts either do not compile, or if any are over the 24kb size limit.testcheck will be skipped if either of the previous 2 steps fail. If any tests fail this check also fails.