refactor: contract size cuts #444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: split most of Factory out to FactoryLib
chore: bump to Solidity 0.8.28 for `transient` keyword
BenSparksCode
requested review from
0x1NotMe,
aanand1,
jj1980a and
thogard785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes (detailed changes in each sub-PR below):
transientkeyword #442Size Diffs
The net effect on contract size is that Atlas.sol is
388 bytesunder the limit, which should be enough room for the additional logic needed in the Arbitrum version.Gas Diffs
Gas costs increased slightly (~0.5%), mostly due to the
delegatecalloverhead needed any time a Factory.sol function is called.