Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 80% bundler refund cap if solvers fail #438

Closed
wants to merge 3 commits into from
Closed

feat: add 80% bundler refund cap if solvers fail #438

wants to merge 3 commits into from

Conversation

BenSparksCode
Copy link
Contributor

Rough draft

@BenSparksCode BenSparksCode mentioned this pull request Oct 2, 2024
Merged
Base automatically changed from solver-surcharge-tracking-2 to solver-surcharge-tracking October 16, 2024 09:36
@BenSparksCode BenSparksCode mentioned this pull request Oct 16, 2024
Merged
@BenSparksCode
Copy link
Contributor Author

Closing in favour of #441 as this PR's changes added too much complexity to the already complex accounting logic, and interfered with the refunding of [deposits - withdrawals] when it wasn't unnecessary.

#441's approach is cleaner and less error-prone.

@BenSparksCode BenSparksCode deleted the solver-surcharge-tracking-3 branch October 16, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BenSparksCode