Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't render collapsed Collapse's children #507

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Don't render collapsed Collapse's children #507

wants to merge 2 commits into from
+32 −30

Commits on Sep 3, 2021

  1. Fix spelling.

    @ddunkin
    ddunkin committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    fc06905 View commit details
    Browse the repository at this point in the history

  2. If a Collapse is collapsed, don't render it instead of hiding it. 

    This reduces DOM elements, SSR size, render time, unnecessary effects (e.g. network calls), etc. for content that isn't visible.

It could be problematic for any consumers that expect their components to be rendered while hidden.
    @ddunkin
    ddunkin committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    04a44e0 View commit details
    Browse the repository at this point in the history