-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1495 #1496
Fix #1495 #1496
Commits on May 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8755ae9 - Browse repository at this point
Copy the full SHA 8755ae9View commit details -
feat(Base): Eliminate extra allocation in
FairVolumeList
* Explicitely delete copy ctor and assignment which were previously private and unimplemented * Disable unused streamer
Configuration menu - View commit details
-
Copy full SHA for 5c3d912 - Browse repository at this point
Copy the full SHA 5c3d912View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82e7b5a - Browse repository at this point
Copy the full SHA 82e7b5aView commit details -
feat(Base): Fix string arguments
* Passing a string ptr and then dereferencing without checking for `nullptr` clearly shows that the intention was to use a C++ reference * Passing a string by value is making an unnecessary copy which can be avoided here.
Configuration menu - View commit details
-
Copy full SHA for dac92e1 - Browse repository at this point
Copy the full SHA dac92e1View commit details -
feat(Base): Prevent memory leak with duplicates in
FairVolumeList
The raw pointer arg is transferring ownership. * In case the given object was not added to the list, it just leaked. * A new overload with a unique_ptr arg avoids the leak and communicates the transfer of ownership.
Configuration menu - View commit details
-
Copy full SHA for 7f0f7f1 - Browse repository at this point
Copy the full SHA 7f0f7f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a0e753 - Browse repository at this point
Copy the full SHA 4a0e753View commit details -
fix(Base): Simplify
FairVolumeList
further* Avoid unnecessary expliciteness and track return value types with `auto` * Use conditional operator for readability
Configuration menu - View commit details
-
Copy full SHA for 4e4a3b6 - Browse repository at this point
Copy the full SHA 4e4a3b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f852585 - Browse repository at this point
Copy the full SHA f852585View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43962df - Browse repository at this point
Copy the full SHA 43962dfView commit details -
refactor(Base): Rewrite loop with
TRangeDynCast
for readability* Rename `aList` to `nodes`, see [S.2](https://github.com/FairRootGroup/FairRoot/blob/master/CONTRIBUTING.md#s2-prefer-variable-names-describing-what-they-contain) * Apply [CPPCG::ES.6](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es6-declare-names-in-for-statement-initializers-and-conditions-to-limit-scope)
Configuration menu - View commit details
-
Copy full SHA for 98aa8ba - Browse repository at this point
Copy the full SHA 98aa8baView commit details -
refactor(Base):
FairModule::ProcessNodes
further* [CPPCG::ES.5 Keep scopes small](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es5-keep-scopes-small) * [CPPCG::ES.11 Use `auto` to avoid redundant repetition of type names](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-auto) * Rename `fNodes` to `parNodes` - the `f`-prefix is reserved for member variables * Default to prefix increment operator for readibility, especially if return value is ignored * `FairGeoNode` is a `FairGeoVolume` - no `dynamic_cast` needed * Explicitely `std::ignore` return values
Configuration menu - View commit details
-
Copy full SHA for fbc4fe6 - Browse repository at this point
Copy the full SHA fbc4fe6View commit details -
refactor(Base): Deduplicate code into `FairModule::RegisterSensitiveV…
…olume()` * Improve maintainability
Configuration menu - View commit details
-
Copy full SHA for e72aa4f - Browse repository at this point
Copy the full SHA e72aa4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 135bd40 - Browse repository at this point
Copy the full SHA 135bd40View commit details