Micro optimizations to player.GetBy* functions

[joeyjumper94]

speed up player.GetBy____ID(ID) functions by relying primarily on indexing a table

[robotboy655]

Is this even necessary? I can't imagine these functions being used in such contexts where they'd cause serious performance issues, for the trade off of uglifying the code and introducing potential reliability issues.

Have you even tested these changes? I am seeing multiple issues just by skimming over the changes.

Not to mention the PR does not adhere to the contributing guidelines.

[robotboy655]

I have also just noticed that this is effectively duplicate of #2094, but with also affecting the other functions.

[joeyjumper94]

here's the code i used to test my changes

for i=1,128 do
	local p=Entity(i)
	if!p:IsValid()then continue end
	if!p:IsPlayer()then break end
	MsgN"_____________________________________________\n"
	MsgN(p)
	local ID=p:AccountID()
	MsgN("player.GetByAccountID(",ID,")=",player.GetByAccountID(ID))
	local ID=p:SteamID()
	MsgN("player.GetBySteamID\"",ID,"\"=",player.GetBySteamID(ID))
	local ID=p:SteamID64()
	MsgN("player.GetBySteamID64\"",ID,"\"=",player.GetBySteamID64(ID))
	local ID=p:UniqueID()
	MsgN("player.GetByUniqueID\"",ID,"\"=",player.GetByUniqueID(ID))
end
MsgN"_____________________________________________\n"