Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current server browser ranking suffers from a few pitfalls that this PR tries to address:
The problem with just doing these two changes is that it would result in servers being ordered almost exclusively by player count. To address this issue, this PR also adds fuzziness to the server list. Fuzziness is basically just a small random number defeating any strict ranking. Instead, the ranking is probabilistic, i.e. more popular servers are more likely to be near the top, but it is not guaranteed. An added benefit is that fuzziness also allows smaller servers to be above bigger ones, but only sometimes.
All the precise numbers used in the PR can of course be up for debate.
Here's an image demonstrating the ping issue of the current ranking.
Here's two images of the ranking this this PR introduces in the DarkRP category:
sample1, sample2, note that each time you refresh, the ranking will be slightly different.