-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bfdd: disable echo socket when not using it #16987
base: master
Are you sure you want to change the base?
Conversation
3d7ffd4
to
1b6ea00
Compare
bfdd/bfd.c
Outdated
|
||
void bfd_vrf_toggle_echo(struct bfd_vrf_global *bfd_vrf) | ||
{ | ||
struct _bfd_session_has_echo has_echo = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we set the correct vrf in has_echo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thank you. I missed that bit.
1b6ea00
to
e6720c8
Compare
once ci finishes I'll get this in. |
e6720c8
to
d1ebd56
Compare
Lets avoid a performance penalty in forwarding when not using the BFD echo feature. The echo socket uses raw packet capturing along with a BPF filter which causes performance issues. Signed-off-by: Rafael Zalamena <[email protected]>
d1ebd56
to
dc52e52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good ... waiting on ci and the one other comment
looks like closing this socket is causing bfdd not to be able to "find itself" ... the test probably needs to be changed (?) |
Fixes #16594.
Lets avoid a performance penalty in forwarding when not using the BFD echo feature. The echo socket uses raw packet capturing along with a BPF filter which causes performance issues.