*: Remove int return for zapi functions #15225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci:rerun CI failed to trigger github check API or so, it's green, but missed a hook |
|
ci:rerun |
|
Hmm - but ... I've thought (sometimes) that getting feedback from zapi apis might be one of the ways we'd be able to do a better job of avoiding buffering when sending to zebra. I'd rather leave that possibility open? |
|
This is reception of data from zebra, not sending of data to zebra. |
riw777
approved these changes
Jan 30, 2024
donaldsharp
force-pushed
the
return_nothing_for_zapi
branch
2 times, most recently
from
7ada350
to
61c95eb
Compare
donaldsharp
force-pushed
the
return_nothing_for_zapi
branch
2 times, most recently
from
de9f6f1
to
02c1576
Compare
|
looks like there are build failures ... :-( |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This PR is stale because it has been open 180 days with no activity. Comment or remove the |
The code never uses the return code for Zapi functions. Let's remove it. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
return_nothing_for_zapi
branch
from
02c1576
to
2020be2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code never uses the return code for
Zapi functions. Let's remove it.