Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler.js #699

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Update compiler.js #699

merged 1 commit into from
Sep 27, 2023

Conversation

jojo535275
Copy link
Contributor

Allow our icestudio verilog code to override the pullmode information coming from pinout.json of the ecp5 boards

Allow our icestudio verilog code to override the pullmode information coming from pinout.json of the ecp5 boards
@cavearr cavearr merged commit 056295d into FPGAwars:develop Sep 27, 2023
4 checks passed
@cavearr
Copy link
Member

cavearr commented Sep 27, 2023

Thanks a lot @jojo535275 !

For future PRs, please check this documentation https://docs.github.com/fr/authentication/managing-commit-signature-verification/about-commit-signature-verification.

It's important to sign your commits to improve the security.

Thanks again!

@jojo535275
Copy link
Contributor Author

Thanks Carlos,
Yes, i have seen that verified warning when i did the PR.
But is was not clear at all how to activate that!
i will try to do it next time ;-)

@cavearr
Copy link
Member

cavearr commented Sep 28, 2023

don't worry! if you need some help with it tell me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants