flush multiple lines together #204
Conversation
flushing multiple lines together noticeably improves performance when many lines are written to the console e.g. when spawning many entities
| */ | ||
| public ConsoleBufferedOutputStream(final JTextPane textPane, final OutputStyle style, int maxBufferLength) { | ||
| this(textPane, style); | ||
| this.maxBufferLength = maxBufferLength; |
There was a problem hiding this comment.
This is probably not as effective, as the stringbuilder is already created in the line above.
| * maxBufferLength | ||
| */ | ||
| public void setMaxBufferLength(int maxBufferLength) { | ||
| this.maxBufferLength = maxBufferLength; |
There was a problem hiding this comment.
What happens if the max buffer length is longer than the current string builder buffer? (it is probably good to enforce some bounds, also in the constructor)
There was a problem hiding this comment.
you're right setters don't make sense in this case as the Stringbuilder is already build in the constructor and changing maxBufferLenght does actually nothing.
There was a problem hiding this comment.
It has some effect if you set it to lower values
There was a problem hiding this comment.
but the Stringbuilder is already build. I dont think changing maxBufferLength after it is build would change the StringBuilder.
this.lineBuffer = new StringBuilder(maxBufferLength * 2);
There was a problem hiding this comment.
the buffer gets flushed immediately if it is >maxBufferLength This would still be effective, even.if the actual buffer size is static
| @@ -43,7 +43,8 @@ | |||
| public class ConsoleBufferedOutputStream extends OutputStream { | |||
|
|
|||
| /** The maximum length of the line buffer. */ | |||
| private int maxBufferLength = 4096; | |||
| static final int STANDART_MAX_BUFFER_LENGTH = 4096; | |||
There was a problem hiding this comment.
DEFAULT_MAX_BUFFER_LENGTH
Currently every new line is flushed to the console individualy.
Flushing multiple lines together noticeably reduces Lag when many lines are written to the console e.g. when spawning many entities.