Limit draw updates

[graefjk]

This change limits the between individual calls of drawEntities(). This way drawEntities() is not called every time a new Entity is created. This can reduce Lag when multible entities are added to the PlayingField at the same time. The time between drawEntities() calls can be changed with the setTimeBetweenDraws method which accepts the time in milliseconds. The time is initially set as 32ms between draw calls, which equates to a maximum of 31.75 Draws/Second. This implements #194.

[buehlefs]

Looks good on first glance. The alternative to implementing the update batching/debouncing in the simulation is to implement it in the playfield drawer

ICGE2/ICGE-Ui/src/main/java/de/unistuttgart/informatik/fius/icge/ui/internal/SwingPlayfieldDrawer.java

Line 192 in 49d372f

public void setDrawables(final List<Drawable> drawables) {

There you could use swing timers to trigger draw updates (this would be a bit nicer than the manual thread spawning and joining here). But I don't know where the biggest performance bottlenecks actually are.

[graefjk]

I chose to implement this here instead of in the playfield drawer since drawEntities executes this.getAllEntities() every time it is called and this.getAllEntities() takes longer the more entities there are.

[buehlefs]

I usually prefer the fast exit form over nesting everything in an if. This makes the method easier to read, as all the fail conditions are at the top and can be ignored for the rest of the method body.

if (!this.awaitingEntityDraw) {
    return; // no updates to draw
}
// rest of the method

[buehlefs]

Looks good now. (But I did not run the code myself, so merge at your own risk.)

[graefjk]

Looks good now. (But I did not run the code myself, so merge at your own risk.)

I cannot merge any pull request as i am not a maintainer of this project

[buehlefs]

It looks like I don't have the rights to make you a project maintainer. You should ensure that you have at least 1-2 active maintainers with the correct access rights (@neumantm should be able to help with that). If you want me to merge just leave me a thumbs up. (but I may not be available for emergency merges on a short notice)