unitests/ASM: Removes unused MemoryRegion configs #4110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FEX's ASM unitests had the problem that they were copy and pasted templates and MemoryRegion was copied in to almost all tests. Very few tests actually use the MemoryRegion they were asking for and instead used none, or the hardcoded memory regions that the TestHarnessRunner provides. This is entirely a sed replacement and minor fixups plus reverts for the few tests that actually use the region asked for.
lioncash
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEX's ASM unitests had the problem that they were copy and pasted templates and MemoryRegion was copied in to almost all tests.
Very few tests actually use the MemoryRegion they were asking for and instead used none, or the hardcoded memory regions that the TestHarnessRunner provides.
This is entirely a sed replacement and minor fixups plus reverts for the few tests that actually use the region asked for.