Feat/handle playing after ended #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add favicon and title
If .play() or a seek is initiated after ended, treat it as a new session and emit loaded. Browsers handle this slightly differently, pressing play when at end of stream is at least partially treated as a seek, but the filter will now treat it as a new playback session and trigger LOADED when video is ready to start playing again.
bwallberg
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested
How to Test
Start playing, seek or play to the end. After
endedhas triggered, press or triggerplay, or seek to anywhere in the video.The filter should reset its internal state, causing
loaded->playingto trigger when playback starts again.Firefox and Chrome both behave somewhat differently, in Chrome the entire action seems to be treated as a seek, while in Firefox only part of the action is treated as a seek. Regardless, media event filter will treat it as a new load and only emit
loaded.