Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable media element reuse #345

Merged
merged 8 commits into from
Jul 2, 2024
Merged

Conversation

martinstark
Copy link
Collaborator

@martinstark martinstark commented Jul 1, 2024

The filter now resets its internal state whenever
src is set on the attached media element.

Closes #2

@martinstark martinstark force-pushed the feat/enable-media-element-reuse branch from b4f3f9e to d93ca01 Compare July 1, 2024 14:14
The filter now resets its internal state whenever
src is set on the attached media element.
@martinstark martinstark force-pushed the feat/enable-media-element-reuse branch from e2fed18 to 5f09dda Compare July 2, 2024 06:54
@bwallberg bwallberg force-pushed the feat/enable-media-element-reuse branch from d8bf40f to 1c748d0 Compare July 2, 2024 07:09
Copy link
Collaborator

@bwallberg bwallberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinstark martinstark merged commit f890c94 into main Jul 2, 2024
2 checks passed
@martinstark martinstark deleted the feat/enable-media-element-reuse branch July 2, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable re-using a video element after "emptied"
2 participants