fixup! feat: mp4 mode handling

Eyevinn · Sep 27, 2024 · de53b42 · de53b42
1 parent 0ad8e46
commit de53b42
Showing 1 changed file with 40 additions and 39 deletions.
diff --git a/src/media-event-filter.ts b/src/media-event-filter.ts
@@ -129,6 +129,7 @@ export const getMediaEventFilter = ({
   };
 
   const isNotReady = (): boolean => state.loading || state.ended;
+  const isReady = () => !isNotReady();
 
   // Reset state of media event filter when a new src is
   // attached to the media element.
@@ -137,57 +138,57 @@ export const getMediaEventFilter = ({
   };
 
   const onCanPlay = (): void => {
-    if (mp4Mode) {
-      // Some MP4 files can stop buffering at readyState 3 (canplay), if mp4Mode is enabled we
-      // trigger canplaythrough at readyState 3.
-      onCanPlayThrough();
-    }
-    if (isNotReady()) return;
+    if (isReady()) {
+      // guard for when an engine sets playbackRate to 0 to continue buffering
+      // recover in "ratechange" event
+      if (mediaElement.playbackRate === 0) {
+        state = {
+          ...state,
+          deferCanPlay: true,
+        };
+
+        return;
+      }
 
-    // guard for when an engine sets playbackRate to 0 to continue buffering
-    // recover in "ratechange" event
-    if (mediaElement.playbackRate === 0) {
       state = {
         ...state,
-        deferCanPlay: true,
+        deferCanPlay: false,
       };
 
-      return;
-    }
-
-    state = {
-      ...state,
-      deferCanPlay: false,
-    };
-
-    // block for handling behaviour after initial load,
-    // like buffer and seek recovery
-    clearRatechangeBufferTimeout();
+      // block for handling behaviour after initial load,
+      // like buffer and seek recovery
+      clearRatechangeBufferTimeout();
 
-    if (state.buffering) {
-      state = {
-        ...state,
-        buffering: false,
-      };
+      if (state.buffering) {
+        state = {
+          ...state,
+          buffering: false,
+        };
 
-      callback(FilteredMediaEvent.BUFFERED);
+        callback(FilteredMediaEvent.BUFFERED);
 
-      if (state.deferPlayingEvent) {
-        onPlaying();
-      }
-    } else if (state.seeking) {
-      state = {
-        ...state,
-        seeking: false,
-        deferSeekedEvent: false,
-      };
+        if (state.deferPlayingEvent) {
+          onPlaying();
+        }
+      } else if (state.seeking) {
+        state = {
+          ...state,
+          seeking: false,
+          deferSeekedEvent: false,
+        };
 
-      callback(FilteredMediaEvent.SEEKED);
+        callback(FilteredMediaEvent.SEEKED);
 
-      if (state.deferPlayingEvent) {
-        onPlaying();
+        if (state.deferPlayingEvent) {
+          onPlaying();
+        }
       }
     }
+    if (mp4Mode) {
+      // Some MP4 files can stop buffering at readyState 3 (canplay), if mp4Mode is enabled we
+      // trigger canplaythrough at readyState 3.
+      onCanPlayThrough();
+    }
   };
 
   const onCanPlayThrough = (): void => {