Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix actor pool initialization in ray client mode #3028

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kevinzwang
Copy link
Member

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Oct 11, 2024
Copy link

codspeed-hq bot commented Oct 11, 2024

CodSpeed Performance Report

Merging #3028 will not alter performance

Comparing kevin/ray-client-actors (617bb53) with main (f5d365b)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 94.55782% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.48%. Comparing base (9ae8122) to head (617bb53).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
daft/runners/partitioning.py 90.47% 6 Missing ⚠️
daft/execution/physical_plan.py 87.50% 1 Missing ⚠️
src/daft-scheduler/src/scheduler.rs 98.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3028      +/-   ##
==========================================
+ Coverage   78.47%   78.48%   +0.01%     
==========================================
  Files         610      610              
  Lines       71740    71778      +38     
==========================================
+ Hits        56297    56336      +39     
+ Misses      15443    15442       -1     
Files with missing lines Coverage Δ
daft/dataframe/dataframe.py 86.57% <100.00%> (-0.02%) ⬇️
daft/execution/native_executor.py 89.47% <100.00%> (+4.47%) ⬆️
daft/execution/rust_physical_plan_shim.py 94.56% <ø> (ø)
daft/io/file_path.py 100.00% <100.00%> (ø)
daft/plan_scheduler/physical_plan_scheduler.py 55.10% <100.00%> (ø)
daft/runners/pyrunner.py 84.00% <100.00%> (-1.26%) ⬇️
daft/runners/ray_runner.py 79.96% <100.00%> (-0.73%) ⬇️
daft/runners/runner.py 76.00% <ø> (+4.12%) ⬆️
daft/execution/physical_plan.py 94.18% <87.50%> (-0.10%) ⬇️
src/daft-scheduler/src/scheduler.rs 93.74% <98.30%> (+0.27%) ⬆️
... and 1 more

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant