Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix reading of logical types from streaming parquet #3027

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

colin-ho
Copy link
Contributor

Follow on from #3026

@github-actions github-actions bot added the bug Something isn't working label Oct 10, 2024
Copy link

codspeed-hq bot commented Oct 10, 2024

CodSpeed Performance Report

Merging #3027 will not alter performance

Comparing colin/parquet-fix-for-streaming (c321470) with main (9ae8122)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.47%. Comparing base (9ae8122) to head (c321470).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3027   +/-   ##
=======================================
  Coverage   78.47%   78.47%           
=======================================
  Files         610      610           
  Lines       71740    71746    +6     
=======================================
+ Hits        56297    56306    +9     
+ Misses      15443    15440    -3     
Files with missing lines Coverage Δ
src/daft-parquet/src/stream_reader.rs 90.62% <100.00%> (+0.07%) ⬆️

... and 2 files with indirect coverage changes

@colin-ho colin-ho merged commit f5d365b into main Oct 11, 2024
41 checks passed
@colin-ho colin-ho deleted the colin/parquet-fix-for-streaming branch October 11, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant