Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Auto attach LLDB debugger to python #2940 #3020

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

sagiahrac
Copy link
Contributor

@github-actions github-actions bot added the chore label Oct 8, 2024
Copy link

codspeed-hq bot commented Oct 8, 2024

CodSpeed Performance Report

Merging #3020 will not alter performance

Comparing sagiahrac:auto-attach-lldb-debugger (d9b2f50) with main (3f37a69)

Summary

✅ 17 untouched benchmarks

@andrewgazelka
Copy link
Member

#2940

@andrewgazelka

Thank you will review this later today

@andrewgazelka
Copy link
Member

Is there a reason we don't include the launch.json file directly in the main repository and instead have it in a Markdown document? It seems like it would be easier if it were directly in the repository.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.44%. Comparing base (396c004) to head (d9b2f50).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3020      +/-   ##
==========================================
+ Coverage   78.36%   78.44%   +0.08%     
==========================================
  Files         602      603       +1     
  Lines       71082    71506     +424     
==========================================
+ Hits        55701    56092     +391     
- Misses      15381    15414      +33     

see 202 files with indirect coverage changes

@sagiahrac
Copy link
Contributor Author

Is there a reason we don't include the launch.json file directly in the main repository and instead have it in a Markdown document? It seems like it would be easier if it were directly in the repository.

Personally, I sometimes include sensitive tokens as environment variables in the launch.json file. Untracking the .vscode directory could help avoid unintentionally altering other users' configurations or accidentally leaking sensitive information... What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants