Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Outer joins for native executor #2860

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Merge branch main into colin/swordfish-outer-join

09c785c
Select commit
Loading
Failed to load commit list.
Open

[FEAT] Outer joins for native executor #2860

Merge branch main into colin/swordfish-outer-join
09c785c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 9, 2024 in 0s

78.21% (+0.06%) compared to 73ff3f3

View this Pull Request on Codecov

78.21% (+0.06%) compared to 73ff3f3

Details

Codecov Report

Attention: Patch coverage is 98.69403% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.21%. Comparing base (73ff3f3) to head (09c785c).

Files with missing lines Patch % Lines
...local-execution/src/sinks/outer_hash_join_probe.rs 98.50% 4 Missing ⚠️
...tion/src/intermediate_ops/inner_hash_join_probe.rs 97.16% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2860      +/-   ##
==========================================
+ Coverage   78.14%   78.21%   +0.06%     
==========================================
  Files         610      611       +1     
  Lines       72146    72345     +199     
==========================================
+ Hits        56381    56584     +203     
+ Misses      15765    15761       -4     
Files with missing lines Coverage Δ
.../src/intermediate_ops/anti_semi_hash_join_probe.rs 96.61% <100.00%> (+0.24%) ⬆️
src/daft-local-execution/src/lib.rs 90.47% <100.00%> (+0.73%) ⬆️
src/daft-local-execution/src/pipeline.rs 92.91% <100.00%> (+1.39%) ⬆️
src/daft-local-execution/src/runtime_stats.rs 55.67% <100.00%> (ø)
.../daft-local-execution/src/sinks/hash_join_build.rs 95.00% <100.00%> (-0.24%) ⬇️
src/daft-local-execution/src/sinks/limit.rs 100.00% <100.00%> (ø)
...c/daft-local-execution/src/sinks/streaming_sink.rs 80.15% <100.00%> (+14.27%) ⬆️
src/daft-table/src/lib.rs 89.51% <ø> (-0.33%) ⬇️
src/daft-table/src/probeable/mod.rs 100.00% <100.00%> (ø)
...tion/src/intermediate_ops/inner_hash_join_probe.rs 97.16% <97.16%> (ø)
... and 1 more

... and 24 files with indirect coverage changes