[BUG] Filter out marker files from glob scan #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
==========================================
+ Coverage 84.67% 84.70% +0.03%
==========================================
Files 58 58
Lines 6363 6363
==========================================
+ Hits 5388 5390 +2
+ Misses 975 973 -2 |
jaychia
approved these changes
Mar 9, 2024
src/daft-io/src/object_store_glob.rs
Outdated
| @@ -309,6 +309,15 @@ fn _should_return(fm: &FileMetadata) -> bool { | |||
| { | |||
| false | |||
| } | |||
| // These are marker files used by Spark that we don't want to return | |||
| FileType::File | |||
| if fm.filepath.ends_with("_metadata") | |||
There was a problem hiding this comment.
Let's do a .lower() on the file names and have these stored as constants?
Ideally it should also be configurable by the user but I think we can ignore that for now.
samster25
reviewed
Mar 11, 2024
src/daft-io/src/object_store_glob.rs
Outdated
| FileType::File | ||
| if MARKER_SUFFIXES | ||
| .iter() | ||
| .any(|suffix| fm.filepath.to_lowercase().ends_with(suffix)) => |
There was a problem hiding this comment.
for _metadata, _common_metadata, and _success this may be bug prone.
Imagine you have a parquet file called image_metadata. this would filter that file out. Instead you want to find an exact match of filename where filename is basepath / filename for those 3.
samster25
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1987