Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] read_sql #1943

Merged
merged 30 commits into from
Mar 13, 2024

refactor and add limit pushdown

bd65b05
Select commit
Loading
Failed to load commit list.
Merged

[FEAT] read_sql #1943

refactor and add limit pushdown
bd65b05
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 13, 2024 in 0s

82.70% (-1.98%) compared to bd78fa8

View this Pull Request on Codecov

82.70% (-1.98%) compared to bd78fa8

Details

Codecov Report

Attention: Patch coverage is 31.73077% with 142 lines in your changes are missing coverage. Please review.

Project coverage is 82.70%. Comparing base (bd78fa8) to head (bd65b05).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1943      +/-   ##
==========================================
- Coverage   84.67%   82.70%   -1.98%     
==========================================
  Files          58       62       +4     
  Lines        6363     6615     +252     
==========================================
+ Hits         5388     5471      +83     
- Misses        975     1144     +169     
Files Coverage Δ
daft/__init__.py 24.24% <ø> (ø)
daft/context.py 76.22% <ø> (ø)
daft/expressions/expressions.py 91.46% <100.00%> (-0.04%) ⬇️
daft/io/__init__.py 95.45% <100.00%> (+0.21%) ⬆️
daft/runners/partitioning.py 82.15% <100.00%> (+0.25%) ⬆️
daft/datatype.py 92.01% <75.00%> (-0.23%) ⬇️
daft/logical/schema.py 91.22% <50.00%> (-0.74%) ⬇️
daft/io/_sql.py 52.94% <52.94%> (ø)
daft/table/table_io.py 89.95% <13.33%> (-5.38%) ⬇️
daft/sql/sql_reader.py 22.41% <22.41%> (ø)
... and 1 more

... and 6 files with indirect coverage changes