Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Populate previews only when show() or __repr__() is called #1889

Merged
merged 7 commits into from
Feb 20, 2024

preview implementation for py and ray runner

38fa51b
Select commit
Loading
Failed to load commit list.
Merged

[CHORE] Populate previews only when show() or __repr__() is called #1889

preview implementation for py and ray runner
38fa51b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 20, 2024 in 0s

85.55% (+0.00%) compared to e47eeda

View this Pull Request on Codecov

85.55% (+0.00%) compared to e47eeda

Details

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e47eeda) 85.55% compared to head (38fa51b) 85.55%.
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1889   +/-   ##
=======================================
  Coverage   85.55%   85.55%           
=======================================
  Files          55       55           
  Lines        6194     6216   +22     
=======================================
+ Hits         5299     5318   +19     
- Misses        895      898    +3     
Files Coverage Δ
daft/dataframe/dataframe.py 87.28% <100.00%> (-0.24%) ⬇️
daft/runners/pyrunner.py 96.17% <100.00%> (+0.24%) ⬆️
daft/runners/ray_runner.py 89.72% <100.00%> (+0.28%) ⬆️
daft/runners/partitioning.py 81.90% <50.00%> (-0.31%) ⬇️

... and 2 files with indirect coverage changes