PSPNet Guide #547

divyanshj16 · 2019-11-14T03:28:29Z

Adds guide for how PSPNet works and how to initialize it inside arcgis.learn.

review-notebook-app · 2019-11-14T03:28:35Z

Check out this pull request on

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

divyanshj16 · 2019-11-14T03:28:58Z

@priyankatuteja Can you have a look?
P.S: This is very early draft, and might contain some typos.

guide/14-deep-learning/how_pspnet_works_and_its_implementation_details_within_arcgis.ipynb

divyanshj16 · 2019-11-18T09:44:02Z

@rohitgeo, @cyber-aman, @Yongyao, @AtmaMani. Could anyone review this?

guide/14-deep-learning/how_pspnet_works_and_its_implementation_details_within_arcgis.ipynb

…to psp_guide

AtmaMani · 2019-12-10T17:48:11Z

@divyanshj16 is this ready? The title says draft

divyanshj16 · 2019-12-11T04:17:13Z

@AtmaMani
Yeah, this is ready. I have changed the title.

AtmaMani · 2019-12-11T17:41:25Z

@Yongyao could you review this

Yongyao · 2019-12-11T18:20:38Z

guide/14-deep-learning/how_pspnet_works_and_its_implementation_details_within_arcgis.ipynb

@@ -0,0 +1,335 @@
+{


"and its paper has more than 1500 citations." -> this number can change quickly. Perhaps we can just say "its paper is one of the most cited papers in the field".

Reply via ReviewNB

changed it to "its paper is highly cited by the computer vision community"

Yongyao · 2019-12-11T18:20:39Z

guide/14-deep-learning/how_pspnet_works_and_its_implementation_details_within_arcgis.ipynb

@@ -0,0 +1,335 @@
+{


We can rephrase the sentence to "For a detailed review of CNNs, please review Stanford University's CS231n: Convolutional Neural Networks for Visual Recognition course." We can provide a hyperlink if we think that link wont change in future

Reply via ReviewNB

Yongyao · 2019-12-11T18:20:39Z

guide/14-deep-learning/how_pspnet_works_and_its_implementation_details_within_arcgis.ipynb

@@ -0,0 +1,335 @@
+{


Can you spell out FCN? People might not know it at this point.
Maybe we should soften the tone a bit. Is it always better? If no, we could change it to "Why PSPNet architecture could be an improvement over FCN based segmentation?

Reply via ReviewNB

Done
Moderated the tone.

Yongyao · 2019-12-11T18:20:39Z

guide/14-deep-learning/how_pspnet_works_and_its_implementation_details_within_arcgis.ipynb

@@ -0,0 +1,335 @@
+{


The legend/label of this figure can be improved. Maybe put them on the top or at the bottom
Consider numbering figures. For example, Figure 1. Image comparing FCN and PSPNet [1]. Same thing for the rest of guide

Reply via ReviewNB

How can I do that? The label is at the bottom and the legend is on the right. This image is directly from the paper. It seems to be a good for me.
Since I am not using figure names in the text, is it still important to add the figure numbers?

If it's hard to change, that's fine.

Yes, adding figure number is considered a good convention.

Left 1. Did 2.
Thanks.

Yongyao · 2019-12-11T18:20:39Z

guide/14-deep-learning/how_pspnet_works_and_its_implementation_details_within_arcgis.ipynb

@@ -0,0 +1,335 @@
+{


Heading "How to set scales in arcgis.learn" looks too small.

Reply via ReviewNB

Increased the heading.

Yongyao · 2019-12-11T18:20:39Z

guide/14-deep-learning/how_pspnet_works_and_its_implementation_details_within_arcgis.ipynb

@@ -0,0 +1,335 @@
+{


Heading is too small

Reply via ReviewNB

Yongyao · 2019-12-11T18:20:40Z

guide/14-deep-learning/how_pspnet_works_and_its_implementation_details_within_arcgis.ipynb

@@ -0,0 +1,335 @@
+{


Heading is too small
To be consistent, can we change the title to "Implementation in arcgis.learn"

Reply via ReviewNB

Yongyao · 2019-12-11T18:20:40Z

guide/14-deep-learning/how_pspnet_works_and_its_implementation_details_within_arcgis.ipynb

@@ -0,0 +1,335 @@
+{


It would be better if you can follow the convention of citing a web page (different from a scientific paper).
For example, [author name, article title, url, accessed date] -> Howard Jeremy. Fastai - Dynamic U-Net. https://www.youtube.com/watch?v=0frKXR-2PBY. Accessed 2 September 2019.
You can refer to https://owl.purdue.edu/owl/research_and_citation/mla_style/mla_formatting_and_style_guide/mla_works_cited_electronic_sources.html for more detail.

Reply via ReviewNB

Yongyao · 2019-12-11T18:23:07Z

@divyanshj16 Great work. I added some comments mostly about format.

…to psp_guide

…-api into psp_guide

divyanshj16 · 2019-12-17T04:40:53Z

Thanks @Yongyao. I have incorporated your changes. Please see my comment on your legend\label comment.

Yongyao

@divyanshj16 Thanks. LGTM. @AtmaMani

guide/14-deep-learning/how_pspnet_works_and_its_implementation_details_within_arcgis.ipynb

AtmaMani · 2019-12-19T23:41:59Z

@divyanshj16 I posted some suggestions can you review them? Further, can you remove the talk notebook and send it to the conference_talks branch as a separate PR?

divyanshj16 · 2019-12-27T03:27:10Z

@AtmaMani I have incorporated your changes.
Are you talking about moving the talks folder, which needs to be moved to conference_talks branch as a seperate PR?

AtmaMani · 2019-12-30T18:55:09Z

@divyanshj16, yes please remove the talks from this PR and send it to the conference_talks branch in a separate PR.

…to psp_guide

divyanshj16 · 2019-12-31T03:38:33Z

@AtmaMani
there is already a talks folder in conference_talks branch.

AtmaMani · 2019-12-31T18:26:01Z

@divyanshj16 thanks for the guide. @priyankatuteja @cyber-aman @Yongyao thanks for your detailed reviews.

divyanshj16 added 3 commits March 5, 2019 13:14

Create Oil_Well_Pads_extraction_training_and_deployment_in_ArcGIS.ipynb

60b7160

Adds Oil Well Pad Detection Deep Learning Workflow notebook.

0f44f2c

adds initial draft of pspnet guide

8b845e4

fix typos and grammatical mistakes

21678c3

priyankatuteja reviewed Nov 14, 2019

View reviewed changes

divyanshj16 added 2 commits November 18, 2019 14:02

Updates PSP guide, incorporates priyanka's suggestions

1b6506e

fix minor typos

360b39f

cyber-aman reviewed Nov 22, 2019

View reviewed changes

divyanshj16 added 2 commits November 25, 2019 11:44

Merge branch 'master' of https://github.com/Esri/arcgis-python-api in…

c5bca07

…to psp_guide

incorporates amandeep suggestions

d3c95b8

divyanshj16 changed the title ~~adds initial draft of pspnet guide~~ PSPNet Guide Dec 11, 2019

AtmaMani requested a review from Yongyao December 11, 2019 17:41

Yongyao reviewed Dec 11, 2019

View reviewed changes

divyanshj16 added 3 commits December 17, 2019 08:53

Merge branch 'master' of https://github.com/Esri/arcgis-python-api in…

dd96021

…to psp_guide

Incorporates Yongyao comments

e751e32

Merge branch 'master' of https://github.com/divyanshj16/arcgis-python…

f16e673

…-api into psp_guide

Add figure numbers.

9d95fe7

Yongyao approved these changes Dec 18, 2019

View reviewed changes

AtmaMani reviewed Dec 19, 2019

View reviewed changes

Incorporates Atma's changes and renames the notebook

819429d

divyanshj16 added 2 commits December 31, 2019 08:25

Merge branch 'master' of https://github.com/Esri/arcgis-python-api in…

d4f19bc

…to psp_guide

Remove talks folder

86bc5d0

AtmaMani approved these changes Dec 31, 2019

View reviewed changes

AtmaMani merged commit 94cc264 into Esri:master Dec 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PSPNet Guide #547

PSPNet Guide #547

divyanshj16 commented Nov 14, 2019

review-notebook-app bot commented Nov 14, 2019

divyanshj16 commented Nov 14, 2019 •

edited

Loading

divyanshj16 commented Nov 18, 2019 •

edited

Loading

AtmaMani commented Dec 10, 2019

divyanshj16 commented Dec 11, 2019 •

edited

Loading

AtmaMani commented Dec 11, 2019

Yongyao Dec 11, 2019 •

edited

Loading

divyanshj16 Dec 17, 2019 •

edited

Loading

Yongyao Dec 11, 2019 •

edited

Loading

divyanshj16 Dec 17, 2019

Yongyao Dec 11, 2019 •

edited

Loading

divyanshj16 Dec 17, 2019

Yongyao Dec 11, 2019

divyanshj16 Dec 17, 2019

Yongyao Dec 17, 2019

divyanshj16 Dec 18, 2019

Yongyao Dec 11, 2019 •

edited

Loading

divyanshj16 Dec 17, 2019

Yongyao Dec 11, 2019 •

edited

Loading

divyanshj16 Dec 17, 2019

Yongyao Dec 11, 2019 •

edited

Loading

divyanshj16 Dec 17, 2019

Yongyao Dec 11, 2019 •

edited

Loading

divyanshj16 Dec 17, 2019

Yongyao commented Dec 11, 2019

divyanshj16 commented Dec 17, 2019

Yongyao left a comment

AtmaMani commented Dec 19, 2019 •

edited

Loading

divyanshj16 commented Dec 27, 2019 •

edited

Loading

AtmaMani commented Dec 30, 2019

divyanshj16 commented Dec 31, 2019

AtmaMani commented Dec 31, 2019

PSPNet Guide #547

PSPNet Guide #547

Conversation

divyanshj16 commented Nov 14, 2019

review-notebook-app bot commented Nov 14, 2019

divyanshj16 commented Nov 14, 2019 • edited Loading

divyanshj16 commented Nov 18, 2019 • edited Loading

AtmaMani commented Dec 10, 2019

divyanshj16 commented Dec 11, 2019 • edited Loading

AtmaMani commented Dec 11, 2019

Yongyao Dec 11, 2019 • edited Loading

Choose a reason for hiding this comment

divyanshj16 Dec 17, 2019 • edited Loading

Choose a reason for hiding this comment

Yongyao Dec 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yongyao Dec 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yongyao Dec 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yongyao Dec 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yongyao Dec 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yongyao Dec 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yongyao commented Dec 11, 2019

divyanshj16 commented Dec 17, 2019

Yongyao left a comment

Choose a reason for hiding this comment

AtmaMani commented Dec 19, 2019 • edited Loading

divyanshj16 commented Dec 27, 2019 • edited Loading

AtmaMani commented Dec 30, 2019

divyanshj16 commented Dec 31, 2019

AtmaMani commented Dec 31, 2019

divyanshj16 commented Nov 14, 2019 •

edited

Loading

divyanshj16 commented Nov 18, 2019 •

edited

Loading

divyanshj16 commented Dec 11, 2019 •

edited

Loading

Yongyao Dec 11, 2019 •

edited

Loading

divyanshj16 Dec 17, 2019 •

edited

Loading

Yongyao Dec 11, 2019 •

edited

Loading

Yongyao Dec 11, 2019 •

edited

Loading

Yongyao Dec 11, 2019 •

edited

Loading

Yongyao Dec 11, 2019 •

edited

Loading

Yongyao Dec 11, 2019 •

edited

Loading

Yongyao Dec 11, 2019 •

edited

Loading

AtmaMani commented Dec 19, 2019 •

edited

Loading

divyanshj16 commented Dec 27, 2019 •

edited

Loading