Use LambdaMetafactory instead of classic reflection whenever possible #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Thanks for the PR, but maybe it is better to use VarHandle for current use case? Edit: nevermind, VarHandle do not really has a proper way to modify final fields. |
UserNugget
requested changes
Aug 7, 2024
plugin/src/main/java/net/elytrium/limboapi/utils/LambdaUtil.java
Outdated
Show resolved
Hide resolved
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LambdaMetafactory 10% slower than a static MethodHandle but 80% faster than a non-static MethodHandle & Reflection
Replaced frequent reflection call to the constant field DEFAULT_PERMISSIONS by own constant
Removed hacky use of sun.misc.Unsafe from LoginListener.java
LMF is not used in one-shot things like LimboProtocol.java
https://stackoverflow.com/questions/19557829/faster-alternatives-to-javas-reflection/19563000#19563000
https://www.optaplanner.org/blog/2018/01/09/JavaReflectionButMuchFaster.html
https://mail.openjdk.org/pipermail/mlvm-dev/2018-February/006817.html