Skip to content

Commit

Permalink
feat(coins-info): support year-varying diameter
Browse files Browse the repository at this point in the history
  • Loading branch information
Eejit43 committed Dec 18, 2023
1 parent bf2c786 commit af3d208
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 2 deletions.
31 changes: 30 additions & 1 deletion src/public/scripts/pages/info/coins-info.ts
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,36 @@ function loadCoinDesignInfo(denomination: CoinDenomination<CoinDesign<FilteredCo
return listElement;
},
},
{ icon: 'circle', name: 'Diameter', value: design.diameter ? `${design.diameter} mm` : null },
{
icon: 'circle',
name: 'Diameter',
value: () => {
if (!design.diameter) return null;

if (typeof design.diameter === 'number') return `${design.diameter} mm`;

const listElement = document.createElement('ul');

for (const yearRange of design.diameter) {
const listItem = document.createElement('li');

if (yearRange.value) listItem.append(`${yearRange.value} mm`);
else {
const unknownSpan = document.createElement('span');
unknownSpan.dataset.unknown = 'true';
unknownSpan.textContent = 'Unknown';

listItem.append(unknownSpan);
}

listItem.append(` (${formatYearRange(yearRange.startYear, yearRange.endYear)})`);

listElement.append(listItem);
}

return listElement;
},
},
{
icon: 'coin-blank',
name: 'Edge',
Expand Down
2 changes: 1 addition & 1 deletion src/route-handlers/coins-list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export interface CoinDesign<Coin> {
active?: true;
composition: { amounts: CoinComposition[] } | { amounts: CoinComposition[]; startYear: number; endYear?: number }[];
mass: number | null | { value: number | null; startYear: number; endYear?: number }[];
diameter: number;
diameter: number | null | { value: number | null; startYear: number; endYear?: number }[];
edge: string | { reeds: number } | { value: string | { reeds: number }; startYear: number; endYear?: number }[];
numistaEntry: number | number[] | false;
wikipediaArticle: string | string[];
Expand Down

0 comments on commit af3d208

Please sign in to comment.