Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DMS-30] Update GitHub actions #72

Merged
merged 20 commits into from
Mar 7, 2024
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/after-pullrequest-bidi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Upload Test Results
uses: dorny/test-reporter@c9b3d0e2bd2a4e96aaf424dbaa31c46b42318226 #v1.6.0
uses: dorny/test-reporter@eaa763f6ffc21c7a37837f56cd5f9737f27fc6c8 # v1.8.0
with:
artifact: bidi-test-results
name: Bidi Tests Results
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/after-pullrequest-powershell.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Upload Test Results
uses: dorny/test-reporter@c9b3d0e2bd2a4e96aaf424dbaa31c46b42318226 #v1.6.0
uses: dorny/test-reporter@eaa763f6ffc21c7a37837f56cd5f9737f27fc6c8 # v1.8.0
andonyns marked this conversation as resolved.
Show resolved Hide resolved
with:
artifact: powershell-analyzer-test-results
name: Tests Results
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/bidi-scanner-demo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout the repo to Scan
uses: actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b # v3.2.0
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

- name: No problems in Allowedlist
uses: ./bidi-scanner
Expand All @@ -38,7 +38,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout the repo to Scan
uses: actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b # v3.2.0
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

- name: Expect this to fail
uses: ./bidi-scanner
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/on-pullrequest-bidi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ jobs:
working-directory: bidi-scanner/cli
steps:
- name: Checkout the Actions repo
uses: actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b # v3.2.0
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

- name: Setup Node
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: 16
node-version: 18
cache: 'npm'
cache-dependency-path: bidi-scanner/cli/package-lock.json

Expand All @@ -46,7 +46,7 @@ jobs:
run: npm run test:ci

- name: Upload test results
uses: actions/upload-artifact@83fd05a356d7e2593de66fc9913b3002723633cb # v3.1.1
uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0
with:
name: bidi-test-results
path: ./bidi-scanner/cli/junit.xml
Expand All @@ -59,12 +59,12 @@ jobs:
working-directory: bidi-scanner/lib
steps:
- name: Checkout the Actions repo
uses: actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b # v3.2.0
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

- name: Setup Node
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: 16
node-version: 18
cache: 'npm'
cache-dependency-path: bidi-scanner/cli/package-lock.json

Expand All @@ -81,12 +81,12 @@ jobs:
working-directory: bidi-scanner/github
steps:
- name: Checkout the Actions repo
uses: actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b # v3.2.0
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

- name: Setup Node
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: 16
node-version: 18
cache: 'npm'
cache-dependency-path: bidi-scanner/cli/package-lock.json

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/on-pullrequest-powershell.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout the Actions repo
uses: actions/checkout@a12a3943b4bdde767164f792f33f40b04645d846 # v3.0.0
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

- name: Run Unit Tests
shell: pwsh
Expand All @@ -38,7 +38,7 @@ jobs:
Invoke-Pester -Configuration $PesterConfig

- name: Upload Test Results
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0
uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0
with:
name: powershell-analyzer-test-results
path: powershell-analyzer/ps-analyzer.xml
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/powershell-analyzer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ jobs:

steps:
- name: Checkout the Actions repo
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
repository: Ed-Fi-Alliance-OSS/Ed-Fi-Actions
repository: ${{ github.repository_owner }}/Ed-Fi-Actions
path: Ed-Fi-Actions

- name: Checkout the repo to review
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
path: testing-repo

Expand All @@ -38,13 +38,13 @@ jobs:
directory: ./testing-repo/

- name: Upload SARIF as Artifact
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0
uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0
with:
name: analysis-result
path: ./results.sarif
retention-days: 10

- name: Upload SARIF to CodeQL
uses: github/codeql-action/upload-sarif@1fae5bf71b0ecdc7d0a2ef0d0c28409d99693966 #v2.9.2
uses: github/codeql-action/upload-sarif@cf7e9f23492505046de9a37830c3711dd0f25bb3 # codeql-bundle-v2.16.2
with:
sarif_file: ./results.sarif
12 changes: 6 additions & 6 deletions .github/workflows/repository-scanner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout the Actions repo
uses: actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b # v3.2.0
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
repository: Ed-Fi-Alliance-OSS/Ed-Fi-Actions
repository: ${{ github.repository_owner }}/Ed-Fi-Actions
path: Ed-Fi-Actions

- name: Checkout the repo to Scan
uses: actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b # v3.2.0
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
path: testing-repo

Expand All @@ -46,13 +46,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout the Actions repo
uses: actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b # v3.2.0
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
repository: Ed-Fi-Alliance-OSS/Ed-Fi-Actions
repository: ${{ github.repository_owner }}/Ed-Fi-Actions
path: Ed-Fi-Actions

- name: Checkout the repo to Scan
uses: actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b # v3.2.0
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
path: testing-repo

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scan-actions-demo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@a12a3943b4bdde767164f792f33f40b04645d846
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

- uses: ./action-allowedlist
name: Scan used actions
Expand Down
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
],
"editor.rulers": [80, 110],
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
"source.fixAll.eslint": "explicit"
},
"psi-header.config": {
"forceToTop": true,
Expand Down
6 changes: 4 additions & 2 deletions action-allowedlist/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,14 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

- uses: ./action-allowedlist
name: Scan used actions
id: scan-action

- name: Upload result file as artifact
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571
uses: actions/26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0
stephenfuqua marked this conversation as resolved.
Show resolved Hide resolved
with:
name: actions
path: ./actions.json
Expand Down
2 changes: 1 addition & 1 deletion bidi-scanner/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ inputs:
default: ''
# outputs: Build failure if characters are detected.
runs:
using: node16
using: node20
andonyns marked this conversation as resolved.
Show resolved Hide resolved
main: github/dist/index.mjs
Loading
Loading