[APIPUB-72] Develop solution for processing rate limited/left over messages when warned #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssages when warned Add retry policy for rate limiting
Add new option to documentation
Test Results173 tests 173 ✅ 5s ⏱️ Results for commit ed2a67d. ♻️ This comment has been updated with latest results. |
Fix typo
DavidJGapCR
reviewed
Sep 17, 2024
| throw new Exception( | ||
| "Unable to reduce resource dependencies for processing key changes as expected (the infinite loop threshold was exceeded during processing)."); | ||
| } | ||
| //if (i == infiniteLoopProtectionThreshold) |
There was a problem hiding this comment.
Can we remove this code?
There was a problem hiding this comment.
I fixed that, we need the code
|
There are some warning with this message |
DavidJGapCR
reviewed
Sep 17, 2024
docs/API-Publisher-Configuration.md
Outdated
| @@ -29,6 +29,7 @@ Defines general behavior of the Ed-Fi API Publisher. | |||
| | Options:EnableRateLimit<br/>`--enableRateLimit` | Indicates whether or not to use rate limiting.<br/>(_Default value: false_) | | |||
| | Options:RateLimitNumberExecutions<br/>`--rateLimitNumberExecutions` | Indicates the maximum number of executions allowed within the defined time window.<br/>(_Default value: 100_) | | |||
There was a problem hiding this comment.
Noticed that this documentation says default value is 100. But in the app Settings file it changed to 30.
Update default value
DavidJGapCR
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add retry policy for rate limiting