Refactor String Vars #3141

Ghabry · 2023-11-02T00:06:48Z

Noteworthy changes:

unordered_map instead of vector to reduce huge waste of memory for sparse string usage (e.g. starting at 1000)
StringView used where possible to reduce copying
Bugfix: Setting variables didn't refresh the interpreter

Uses less memory when the string variables are sparse.

Makes writing Unit tests easier later.

…OrVariable

jetrotal · 2023-11-12T20:49:46Z

Hi, we spoke about supporting more file types for the StrVars load/save files,
maybe those change could also fit this pr:

Ghabry added 4 commits November 2, 2023 01:02

String Var: Use std::unordered_map instead of std::vector

797157d

Uses less memory when the string variables are sparse.

String Var: Use StringView where possible instead of copying

fc56095

String Var: Explicitly pass in Game_Variables

f50c10b

Makes writing Unit tests easier later.

String Var: GetWithMode: Swap mode and arg for consistency with Value…

d3d36b0

…OrVariable

Ghabry added the Refactor label Nov 2, 2023

Ghabry added this to the 0.8.1 milestone Nov 2, 2023

Ghabry mentioned this pull request Nov 2, 2023

Maniac: Implement CallCommand and String Vars #3140

Merged

Ghabry force-pushed the maniac/stringvars branch from e80859d to d3d36b0 Compare November 2, 2023 13:05

fdelapena approved these changes Nov 2, 2023

View reviewed changes

fdelapena added the Performance Related to improvements on memory, less CPU or disk usage, battery savings, etc. label Nov 2, 2023

fdelapena merged commit e614030 into EasyRPG:master Nov 17, 2023
12 checks passed

Ghabry deleted the maniac/stringvars branch September 2, 2024 18:52

Provide feedback