-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destiny Patch support #3131
base: master
Are you sure you want to change the base?
Destiny Patch support #3131
Conversation
Nice! Some Documentation, to help contextualize this patch: Destiny Patch 2.0 (also from Bananen-Joe) + Maniacs Update, by Kotatsu Akira: |
Hello. As adding the rest of destiny will be a huge task I have to ask: Your code looks good but do you feel confident enough in C++ to implement the rest of it?
|
Hm actually the grammar doesn't look too hard to parse because the language lacks flow control like if and for. Very straightforward. I can offer my help here if you encounter problems. |
src/destiny.cpp
Outdated
@@ -0,0 +1,160 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo this is a good start. Just a little nit-pick:
Can you rename it to Game_Destiny
similiar to how Ineluki patch is implemented (which is Game_Ineluki
).
Then make it a class and put the instance variable in main_data.h/cpp
and instantiate it in ResetGameObjects
.
Also please update Makefile.am
and CMakeLists.txt
by adding the new files to it (put them at the correct location in alphabetical order).
Yes I know that DynRPG does it in a different way but I plan to rewrite this as less global state makes the cleanup easier when switching the game.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, no problem. I thought that I must create a singleton, but if already exists a container so it's much better.
I'll make this fixes. =D
Thanks for the tips.
Thanks for the feedback! Maybe the interpreter I could use OOP. |
If you think you can implement such a parser then go for it :). When it is flexible enough it can also be used for other parts as you proposed (Maniac has nothing to parse on the player side but there is an expression parser needed for the editor.) |
I'm going to start implementing Destiny Patch support on EasyRPG.
I hope can help.
Awaiting for a feedback. Thanks! =D