Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt at a fix for multi-game functionality #3080

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

sorlok
Copy link
Contributor

@sorlok sorlok commented Sep 7, 2023

Hi all,

I implemented the "multi game" functionality a while ago, and it seems that a recent-ish commit broke it. I've done a cursory fix of the functionality, and confirmed that it now works on "The Way: Episode 2". The fix uses "FileSystemView::Exists()" (rather than "FindFile") since it needs to access files outside of the save directory (e.g., from "Episode1" we need to read "../Episode2/<save_files>".

This also fixes a few smaller issues: infinite looping in Update(), and failing to call Start() in the parent class. Tested on Windows.

Definitely open to suggestions and comments, but I'd like to get this feature back to (at least) what it was doing before.

Thanks!

@Ghabry
Copy link
Member

Ghabry commented Sep 8, 2023

Oh my bad. I completely forgot about this feature and that it is still broken :/

Thanks for the suggested fix. I will review it next week

@sorlok
Copy link
Contributor Author

sorlok commented Sep 15, 2023

Any idea why Android is failing? I see:

> [CXX1409] /var/lib/jenkins/workspace/player-android-pr/builds/android/app/.cxx/Debug/303n5v6u/arm64-v8a/android_gradle_build.json debug|arm64-v8a : expected buildFiles file '/var/lib/jenkins/workspace/player-android-pr/builds/cmake/Modules/Findlhasa.cmake' to exist

...but I definitely didn't change that file.

@Ghabry
Copy link
Member

Ghabry commented Sep 15, 2023

That's a caching issue. Ignore it

@Ghabry
Copy link
Member

Ghabry commented Sep 20, 2023

I think the problem here was that for a proper "go up" the full path to the directory is required instead of "." and getting the path was never implemented.

Though considering that this feature is quite exotic I think your workaround is fine for now. (also the saves would be somewhere else when the game is in a ZIP making the problem even harder ^^')

@Ghabry Ghabry merged commit c35380f into EasyRPG:master Sep 20, 2023
11 of 12 checks passed
@sorlok
Copy link
Contributor Author

sorlok commented Sep 20, 2023

Thanks, that all makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants