Battle: Fix broken animation when the sprite is flipped #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broke the rendering as the same happens now in the sprite class for use by pictures.
|
Jenkins: test this please |
fdelapena
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing flipped spritesheets I forgot to consider that battle sprites can be also flipped.
The battle sprites contained adjustment for the src_rect when they were flipped. As I added a fix to the sprite class this means it was double-inverted and broke.
Solved this by removing all the adjustment code from the battle sprites.
(seeing these workarounds this means that this was a long-standing bug in the flip-code)
Please test various 2k3 games and check if the battles look correct!
I tested: